-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace overheated with the three new fields for plugs #254
Replace overheated with the three new fields for plugs #254
Conversation
The field has changed from a |
Also it's unclear to me if we want to align the python API, how to make an alias, etc. |
75ef917
to
dae6b5d
Compare
It would be best to update the plugs only for now and have the field called If you're happy to make the Rust changes, I can do the Python ones afterwards. |
…eated or overheated_status, make it an enum, and optional
dae6b5d
to
bf5db1c
Compare
Updated. For some reason the up-to-date p110 and p115 don't have this overheated field right now so I left it as optional. |
Thank you for this. |
overheated
or overheated_status
--------- Co-authored-by: Dinculescu <mihai.dinculescu@outlook.com>
This should fix #248 while ensuring older devices keep working if the library is updated but not the firmare of the device.
I only have P110 and P115, but updated all other devices -- those are untested but it should be harmless if it hasn't been renamed there.