Skip to content
This repository was archived by the owner on Jul 15, 2022. It is now read-only.

Commit bb1453b

Browse files
committed
Remove some uses of repackaged Google classes with a more recent version
of Guava and Apache Commons.
1 parent 614cff3 commit bb1453b

File tree

9 files changed

+14
-10
lines changed

9 files changed

+14
-10
lines changed

.classpath

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
<classpathentry kind="lib" path="war/WEB-INF/lib/rome-1.0.jar"/>
88
<classpathentry kind="lib" path="war/WEB-INF/lib/xercesImpl.jar"/>
99
<classpathentry kind="lib" path="war/WEB-INF/lib/json_simple-1.1.jar"/>
10-
<classpathentry kind="lib" path="war/WEB-INF/lib/google-collect-1.0-rc2.jar"/>
1110
<classpathentry kind="lib" path="war/WEB-INF/lib/rome-opml-0.1-fixed.jar"/>
11+
<classpathentry kind="lib" path="war/WEB-INF/lib/guava-11.0.1.jar"/>
12+
<classpathentry kind="lib" path="war/WEB-INF/lib/commons-lang3-3.1.jar"/>
1213
<classpathentry kind="output" path="war/WEB-INF/classes"/>
1314
</classpath>

src/info/persistent/pushbot/PushSubscriberServlet.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package info.persistent.pushbot;
22

33
import com.google.appengine.api.xmpp.JID;
4-
import com.google.appengine.repackaged.com.google.common.base.StringUtil;
4+
import com.google.common.base.Strings;
55
import com.google.common.collect.Lists;
66

77
import com.sun.syndication.feed.synd.SyndEntry;
@@ -12,6 +12,8 @@
1212
import info.persistent.pushbot.util.Persistence;
1313
import info.persistent.pushbot.util.Xmpp;
1414

15+
import org.apache.commons.lang3.StringEscapeUtils;
16+
1517
import java.io.IOException;
1618
import java.net.URL;
1719
import java.util.Collections;
@@ -130,16 +132,16 @@ protected void doPost(HttpServletRequest req, HttpServletResponse resp)
130132
}
131133

132134
StringBuilder message = new StringBuilder("Update from ")
133-
.append(StringUtil.unescapeHTML(feed.getTitle())).append(":");
135+
.append(StringEscapeUtils.unescapeHtml4(feed.getTitle())).append(":");
134136
for (SyndEntry displayEntry : displayEntries) {
135137
String title = displayEntry.getTitle();
136-
if (StringUtil.isEmptyOrWhitespace(title)) {
138+
if (Strings.isNullOrEmpty(title)) {
137139
title = "(title unknown)";
138140
} else {
139-
title = StringUtil.unescapeHTML(title);
141+
title = StringEscapeUtils.unescapeHtml4(title);
140142
}
141143
String link = displayEntry.getLink();
142-
if (StringUtil.isEmptyOrWhitespace(link)) {
144+
if (Strings.isNullOrEmpty(link)) {
143145
link = "<no link>";
144146
}
145147

src/info/persistent/pushbot/commands/ListSubscriptionsCommandHandler.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package info.persistent.pushbot.commands;
22

33
import com.google.appengine.api.xmpp.JID;
4-
import com.google.appengine.repackaged.com.google.common.base.StringUtil;
54
import com.google.common.collect.ArrayListMultimap;
65
import com.google.common.collect.Multimap;
76

87
import info.persistent.pushbot.data.Subscription;
98
import info.persistent.pushbot.util.Xmpp;
109

10+
import org.apache.commons.lang3.StringEscapeUtils;
11+
1112
import java.util.List;
1213

1314
public class ListSubscriptionsCommandHandler implements CommandHandler {
@@ -36,7 +37,7 @@ public void handle(JID user, String... args) {
3637
String title = subscription.getTitle();
3738
if (title != null && !title.isEmpty()) {
3839
message.append(" (")
39-
.append(StringUtil.unescapeHTML(title)).append(")");
40+
.append(StringEscapeUtils.unescapeHtml4(title)).append(")");
4041
}
4142
}
4243
}

src/info/persistent/pushbot/util/Feeds.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package info.persistent.pushbot.util;
22

33
import com.google.appengine.repackaged.com.google.common.base.Hash;
4-
import com.google.appengine.repackaged.com.google.common.io.ByteStreams;
54
import com.google.common.collect.Lists;
5+
import com.google.common.io.ByteStreams;
66

77
import com.sun.syndication.feed.atom.Entry;
88
import com.sun.syndication.feed.rss.Guid;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- Indices written at Sun, 11 Oct 2009 22:01:54 UTC -->
1+
<!-- Indices written at Tue, 10 Jan 2012 16:52:47 UTC -->
22

33
<datastore-indexes/>
44

5.92 KB
Binary file not shown.

war/WEB-INF/lib/commons-lang3-3.1.jar

308 KB
Binary file not shown.
-562 KB
Binary file not shown.

war/WEB-INF/lib/guava-11.0.1.jar

1.57 MB
Binary file not shown.

0 commit comments

Comments
 (0)