Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate non-trivial background-image css definitions #21

Closed
codycushing opened this issue Feb 12, 2015 · 1 comment
Closed

Accommodate non-trivial background-image css definitions #21

codycushing opened this issue Feb 12, 2015 · 1 comment
Assignees
Labels

Comments

@codycushing
Copy link

Looks like the regex is not accounting for characters between url( and /* (no)embed */, causing other valid css syntax to be skipped. For example, these images are not picked up:

background: transparent url(../img/menu.svg) center center no-repeat; /* embed */
background-image: -webkit-image-set(url("../img/Billing-Icon.png") 1x, url("../img/Billing-Icon_2x.png") 2x); /* embed */
@mihhail-lapushkin
Copy link
Owner

Well, you are excluding/including URLs, not CSS properties, so the comment should go right after the appropriate URL:

background: transparent url(../img/menu.svg) /* embed */ center center no-repeat;
background-image: -webkit-image-set(url("../img/Billing-Icon.png") /* embed */ 1x, url("../img/Billing-Icon_2x.png") /* embed */ 2x);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants