Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to cache SPM packages #112

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

rizwankce
Copy link
Contributor

@rizwankce rizwankce commented Oct 9, 2023

What it Does

How I Tested

  • Tested on my fork repo. Please check the link for the difference

Notes

  • Caching was able to save some time for the each build. For the first time since there is no cache it will run on usual time but from the second time onwards it will be little faster.
  • first run without cache takes 7m 31s and second run with cache takes 5m 16s

Screenshot

Screenshot 2023-10-09 at 12 24 53 PM
Screenshot 2023-10-09 at 12 25 01 PM

@rizwankce
Copy link
Contributor Author

@mikaelacaron This PR tackles the speediness of the CI job. We don't get consistent data from the GitHub runners - but we do get 3min savings from the SPM caching.

Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever going to be a need to delete the cache? Should we make a manual action, for if that is ever needed?

@mikaelacaron mikaelacaron merged commit e1999e7 into mikaelacaron:dev Oct 9, 2023
1 check passed
@rizwankce
Copy link
Contributor Author

@mikaelacaron

We don't need to delete the cache. It's automatically done on every job. However for stored cache can be deleted from GitHub UI.

Do we need to delete it in any circumstance?

@mikaelacaron
Copy link
Owner

However for stored cache can be deleted from GitHub UI.
How do I do that?

I'm guessing if there's ever an issue with the CI, at some point we'd want to be able to delete the cache as a first troubleshooting step?

@mikaelacaron
Copy link
Owner

@rizwankce I don't think the cache has made a difference for me, it's still taking 6-7 minutes to run the deploy documentation job

@rizwankce
Copy link
Contributor Author

@mikaelacaron it will work only on second time onwards. However I will check on this ropo GitHub actions.

@mikaelacaron
Copy link
Owner

No worries at all, I'm letting you know, so far, I haven't seen any impact.

@rizwankce
Copy link
Contributor Author

Just take a look at it. Time saving is not as significant as I saw before on my repo.

I'm gonna take another look at it. I'll send a PR if I found better solution.

@mikaelacaron
Copy link
Owner

sounds good! it's not critical so it's fine if you want to move onto different issues!

@rizwankce
Copy link
Contributor Author

@mikaelacaron its seems the performance of the CI machines is not consistent. Now I see 4 mins job on this repo. In that only 2 mins for building the doc. It could be based on the Github Free plan. Im not sure.

So I will move with other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMPROVE - Build time for docc generation with Github Action
2 participants