-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to cache SPM packages #112
Conversation
@mikaelacaron This PR tackles the speediness of the CI job. We don't get consistent data from the GitHub runners - but we do get 3min savings from the SPM caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ever going to be a need to delete the cache? Should we make a manual action, for if that is ever needed?
We don't need to delete the cache. It's automatically done on every job. However for stored cache can be deleted from GitHub UI. Do we need to delete it in any circumstance? |
I'm guessing if there's ever an issue with the CI, at some point we'd want to be able to delete the cache as a first troubleshooting step? |
@rizwankce I don't think the cache has made a difference for me, it's still taking 6-7 minutes to run the deploy documentation job |
@mikaelacaron it will work only on second time onwards. However I will check on this ropo GitHub actions. |
No worries at all, I'm letting you know, so far, I haven't seen any impact. |
Just take a look at it. Time saving is not as significant as I saw before on my repo. I'm gonna take another look at it. I'll send a PR if I found better solution. |
sounds good! it's not critical so it's fine if you want to move onto different issues! |
@mikaelacaron its seems the performance of the CI machines is not consistent. Now I see 4 mins job on this repo. In that only 2 mins for building the doc. It could be based on the Github Free plan. Im not sure. So I will move with other issues. |
What it Does
How I Tested
Notes
7m 31s
and second run with cache takes5m 16s
Screenshot