Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for git repo being clean before bumping up version in package.json and component.json #4

Closed
jimhigson opened this issue Nov 1, 2013 · 2 comments

Comments

@jimhigson
Copy link

If the git repo isn't clean, mversion will edit the json files and then fail to tag. This is bad because if you tidy the git repo and call mversion again it isn't obvious that your project will be bumped up two versions.

I think it should check first and only edit the json files if the git repo is ready to be tagged. Otherwise, print an error and exit.

@mikaelbr
Copy link
Owner

mikaelbr commented Nov 1, 2013

Thanks for your input. You're absolutely right. Fixed in v0.2.1.

@mikaelbr mikaelbr closed this as completed Nov 1, 2013
@jimhigson
Copy link
Author

Awesome. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants