Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug "HRESULT : 0xC00CE508" exception on Win8 #49

Merged
merged 1 commit into from
Mar 19, 2015

Conversation

operandom
Copy link
Contributor

No description provided.

@mikaelbr
Copy link
Owner

I'm not entirely agreeing with myself about this, but I feel this issue is due to a misuse on gulp-notifys part (piping in terminal coloured text), and should maybe not be compensated in this library. There are probably many other characters that can break / crash toaster as well. Or what do you think?

@operandom
Copy link
Contributor Author

This library is the closest to "toast.exe" and I think it's its role to prevent errors from incoming characters, independently of what people sent to notifier.

As example, this code generate an error:

notify.onError('Error: <%= error.message %>')({
    message: String.fromCharCode(27)
})

mikaelbr added a commit that referenced this pull request Mar 19, 2015
Debug "HRESULT : 0xC00CE508" exception on Win8
@mikaelbr mikaelbr merged commit 2a42941 into mikaelbr:master Mar 19, 2015
@mikaelbr
Copy link
Owner

I thought about it and I agree. Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants