Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deleting a player; and for external_player_id #34

Closed
wants to merge 7 commits into from

Conversation

reachire-smendola
Copy link
Contributor

@reachire-smendola reachire-smendola commented Oct 18, 2021

Added support for deleting a Player (required adding http DELETE command support)
Added support for external_player_id

Remember to assign the pull request to a CODEOWNER for review.

ALWAYS open PRs targeting develop, as it is our mainline branch. Master is only used to cut stable releases.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have added tests for each new piece of code I added, or updated existing tests if I changed some existing code
  • I have added the relevant entry in the Unreleased section of the CHANGELOG file
  • I have made corresponding changes to the documentation (namely the README file)

@MatteoJoliveau
Copy link
Collaborator

Hi @reachire-smendola, thank you for your contribution! May I ask you to add some unit tests for the new features you added, as well as some example usage in the README?

@reachire-smendola
Copy link
Contributor Author

Done!

Copy link
Collaborator

@MatteoJoliveau MatteoJoliveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, thank you very much!

@MatteoJoliveau
Copy link
Collaborator

@reachire-smendola I just need you to rebase on develop and resolve the conflicts and then we're good to go!

@reachire-smendola reachire-smendola deleted the branch mikamai:develop October 21, 2021 16:30
@reachire-smendola reachire-smendola deleted the develop branch October 21, 2021 16:30
@reachire-smendola reachire-smendola restored the develop branch October 21, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants