Support for deleting a player; and for external_player_id (alt PR) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachire-smendola
requested review from
bernardini687 and
MatteoJoliveau
as code owners
|
In attempting the rebase, I ended up renaming the branch, which closed my original PR. This is just re-submitting the same code change as in PR#34, but rebased on develop |
|
Just released 0.6.0 with these changes 🎉 |
|
Excellent! TY., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for deleting a Player (required adding http DELETE command support)
Added support for
external_player_idRemember to assign the pull request to a CODEOWNER for review.
ALWAYS open PRs targeting develop, as it is our mainline branch. Master is only used to cut stable releases.
Type of change
Please delete options that are not relevant.
Checklist
Unreleasedsection of the CHANGELOG file