Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 502 Server Error from OneSignal Servers #45

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

yltsrc
Copy link

@yltsrc yltsrc commented Mar 2, 2023

Hello,

while we are working with OneSignal Client we faced with issue when OneSignal Server returns 502 error with an html response, which breaks JSON.parse code.
so I fixed it, and now OneSignal::Client handle_errors without crashes.

Please merge it or tell me what should I do to get this pull request merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant