- Fixed platform id for some regions #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I can't merge it unless you provide updated specs. Do you think you can do this? Thank you a lot :) |
|
Yes, sorry. Done! |
|
@intinig you think it's ready? |
intinig
added a commit
that referenced
this pull request
May 4, 2015
- Fixed platform id for some regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regions like LAS, the platform id for getting the current game is LA2, so concatenating the region with platform id does not work (LAS2 vs LA2).
This quick fix works, but now you have to provide the full platform id when calling
current_game.spectator_game_infoFor example:
client.current_game.spectator_game_info 'LA2', 1121093