Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated stats request to 1.2 #6

Merged
merged 3 commits into from
Dec 27, 2013
Merged

Conversation

nicolaracco
Copy link
Collaborator

Due to the number of properties described for AggregatedStatsDto I preferred to remove the AggregatedStatistic object and to replace it with an hash.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8ad4bbc on nicolaracco:stats_request into 44f232a on mikamai:master.

@intinig
Copy link
Contributor

intinig commented Dec 25, 2013

Can't you use an automated way to map the attributes and make it an openstruct or something? And did you check both for ranked and summary?

@nicolaracco
Copy link
Collaborator Author

Yes I could use open struct and convert all properties in underscore. I
checked only for summary.

2013/12/25 Giovanni Intini notifications@github.com

Can't you use an automated way to map the attributes and make it an
openstruct or something? And did you check both for ranked and summary?


Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-31196972
.

Nicola Racco -- nicola.racco@gmail.com

@intinig
Copy link
Contributor

intinig commented Dec 27, 2013

So I am going to wait for a revised pull request. Thx!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d6a85bc on nicolaracco:stats_request into 44f232a on mikamai:master.

@nicolaracco
Copy link
Collaborator Author

done

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 94817a7 on nicolaracco:stats_request into 44f232a on mikamai:master.

intinig added a commit that referenced this pull request Dec 27, 2013
@intinig intinig merged commit e9a4f6d into mikamai:master Dec 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants