Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoloading classes #7

Merged
merged 2 commits into from
Jan 12, 2014
Merged

Autoloading classes #7

merged 2 commits into from
Jan 12, 2014

Conversation

spaghetticode
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7a98d71 on spaghetticode:master into fbf2d39 on mikamai:master.

intinig added a commit that referenced this pull request Jan 12, 2014
@intinig intinig merged commit b218641 into mikamai:master Jan 12, 2014
@intinig
Copy link
Contributor

intinig commented Jan 12, 2014

I don't really like guard but I kinda like the autoloader :)

@spaghetticode
Copy link
Contributor Author

I knew that, in fact the autoloader file was just the trojan horse to get guard gem added ;-)

@nicolaracco
Copy link
Collaborator

It doesn't seem to work as expected:
inside irb (ruby 2.1.0):

2.1.0p0 :001 > require 'lol'
 => true
2.1.0p0 :002 > Lol::Client.new 'asd'
NameError: uninitialized constant Lol::Client
    from (irb):2
    from /home/.rvm/rubies/ruby-2.1.0/bin/irb:11:in `<main>'

2.1.0p0 :003 > require 'lol/client'
 => true
2.1.0p0 :004 > c = Lol::Client.new 'asd'
 => #<Lol::Client:0x000001013b6198 @api_key="asd", @region="euw">
2.1.0p0 :005 > c.summoner 1
ArgumentError: wrong number of arguments (1 for 0)
    from /home/.rvm/gems/ruby-2.1.0/gems/ruby-lol-0.9.8/lib/lol/client.rb:38:in `summoner'
    from (irb):5
    from /home/.rvm/rubies/ruby-2.1.0/bin/irb:11:in `<main>'

@intinig
Copy link
Contributor

intinig commented Jan 30, 2014

Can you try ruby2?

Sent from GNU Emacs

On 30/gen/2014, at 15:24, Nicola Racco notifications@github.com wrote:

It doesn't seem to work as expected:
inside irb (ruby 2.1.0):

2.1.0p0 :001 > require 'lol'
=> true
2.1.0p0 :002 > Lol::Client.new 'asd'
NameError: uninitialized constant Lol::Client
from (irb):2
from /home/.rvm/rubies/ruby-2.1.0/bin/irb:11:in `

'

2.1.0p0 :003 > require 'lol/client'
=> true
2.1.0p0 :004 > c = Lol::Client.new 'asd'
=> #<Lol::Client:0x000001013b6198 @api_key="asd", @region="euw">
2.1.0p0 :005 > c.summoner 1
ArgumentError: wrong number of arguments (1 for 0)
from /home/.rvm/gems/ruby-2.1.0/gems/ruby-lol-0.9.8/lib/lol/client.rb:38:in summoner' from (irb):5 from /home/.rvm/rubies/ruby-2.1.0/bin/irb:11:in

'

Reply to this email directly or view it on GitHub.

@nicolaracco
Copy link
Collaborator

Same behaviour with ruby 2.0.0 p353

2014-01-30 Giovanni Intini notifications@github.com

Can you try ruby2?

Sent from GNU Emacs

On 30/gen/2014, at 15:24, Nicola Racco notifications@github.com
wrote:

It doesn't seem to work as expected:
inside irb (ruby 2.1.0):

2.1.0p0 :001 > require 'lol'
=> true
2.1.0p0 :002 > Lol::Client.new 'asd'
NameError: uninitialized constant Lol::Client
from (irb):2
from /home/.rvm/rubies/ruby-2.1.0/bin/irb:11:in `

'

2.1.0p0 :003 > require 'lol/client'
=> true
2.1.0p0 :004 > c = Lol::Client.new 'asd'
=> #<Lol::Client:0x000001013b6198 @api_key="asd", @region="euw">
2.1.0p0 :005 > c.summoner 1
ArgumentError: wrong number of arguments (1 for 0)
from
/home/.rvm/gems/ruby-2.1.0/gems/ruby-lol-0.9.8/lib/lol/client.rb:38:in
summoner' from (irb):5 from /home/.rvm/rubies/ruby-2.1.0/bin/irb:11:in

'

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-33693880
.

Nicola Racco -- nicola.racco@gmail.com

@spaghetticode
Copy link
Contributor Author

See #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants