fix: starting telescope or grug-far when hovering a directory #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue:
Given the following directory structure:
- root/
- dir1/
- file1
- file2
When hovering `dir1/` and starting the search or replace operation, the
operation would only consider the files in `dir1/`. This is not what the
user would expect. The user would expect the operation to consider the
files in `root/`.
Solution:
When hovering a directory, we should consider the directory the hovered
directory is in. This is the same behavior as when hovering a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Given the following directory structure:
When hovering
dir1/and starting the search or replace operation, the operation would only consider the files indir1/. This is not what the user would expect. The user would expect the operation to consider the files inroot/.Solution:
When hovering a directory, we should consider the directory the hovered directory is in. This is the same behavior as when hovering a file.