Remove need to initialize child class #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the module. wrapped it in private method that will auto initialize it null
| @@ -6,12 +6,6 @@ class EventedClass | |||
| event :stuff_happens | |||
| event :other_stuff_happens | |||
|
|
|||
| def initialize | |||
There was a problem hiding this comment.
This is no longer need and nicely cleans up the class a bit
|
That's very similar to how I was doing it originally but unfortunately that is not threadsafe. If two threads call the method that instantiates the mutex at the exact same time they can end up with a different mutex. See this gist to see how that might happen: https://gist.github.com/1031308 I do greatly appreciate the effort though. Thanks! |
| RSpec::Core::RakeTask.new do |t| | ||
| t.pattern = "./spec/**/*_spec.rb" # don't need this, it's default. | ||
| end | ||
|
|
There was a problem hiding this comment.
Good idea, I should be running my specs in the rake file when building the gem but I do continuous testing so didn't think to add them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I made a change on how the @eventable_mutex is accessed.
Added a private method that wraps the access to the instance variable that will initialise it if null. This will remove the need for the user to add an initialize method with super which just cleans up the code a bit.
Also added the rspec rake tasks.
Cheers
Colin