Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide java port #8

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Conversation

nick-stephen
Copy link
Collaborator

I got the OK to contribute the port.

No examples yet other than unit tests.

Very simple readme.md

Please let me know if you'd like something changed / improved before merge.

If you're OK with the suggestion I propose using this to release a jar of the library to maven central under com.vmware.antlr4c3 antlr4-c3-.jar - this is since I did this on vmware time.

I also suggest that the version numbers of java and javascript don't try to be aligned so that they can be released separately, in which case the java version might release with version 1.0.0 initially, otherwise I'd be fine aligning them starting with 1.1.5 (but the codebases aren't 100% identical and maybe one will add things the other won't have or not straight away anyway, so the versions will drift...

Thx

Nick

Copy link
Owner

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No intention to provide a port of the symbol table? It's not mandatory (we could use antlr's symtab instead), just asking.

@mike-lischke mike-lischke merged commit 9e3ee7b into mike-lischke:master Aug 27, 2017
@mike-lischke
Copy link
Owner

mike-lischke commented Aug 27, 2017

I'm fine with releasing a jar on maven central, though I have no idea how to do that. And I guess it doesn't matter if both version numbers are in sync.

@nick-stephen
Copy link
Collaborator Author

nick-stephen commented Aug 27, 2017 via email

@mike-lischke
Copy link
Owner

Understandable. As I said, it's not mandatory to have a symbol table in the port. I'm glad about any further contribution you might have!

However, one thing we need to do yet: please sign the (new) contributors.txt list (in the root of the repo). This is essential to fully accept your contribution. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants