Adds 'mon' for Month #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @IanMitchell, Thanks for this! Happy to merge this in, but could you make a few small changes:
|
1 similar comment
IanMitchell
commented
Nov 15, 2016
| @@ -15,6 +15,51 @@ describe('timestring', function() { | |||
| expect(timestring('1y')).to.equal(29030400); | |||
| }); | |||
|
|
|||
| it('can parse different unit identifiers', function() { | |||
| var unitMap = { | |||
There was a problem hiding this comment.
I had to duplicate the map since it isn't exported, but I think violating DRY is ok here since looping over the unit types really reduces the amount of code. Happy to change how I wrote this test if you disagree though!
There was a problem hiding this comment.
Ah no problem, i like what you've done with the test, nice one 👍
|
@IanMitchell Thanks for this! |
|
Released |
|
Thanks, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an abbreviation for month that I see most commonly in the app I'm working on