Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken build steps #454

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Conversation

mike42
Copy link
Owner

@mike42 mike42 commented Oct 29, 2017

This pull request brings the build back into a passing state. It has been failing due to Travis CI changes.

  • disable HHVM, which no longer installs
  • remove PHP 5.3, which also no longer installs
  • add ghostscript install, solves "error running delegate" on Travis CI

Skip integration tests that are not bit-for-bit repeatable on Travis CI.

Was able to confirm that the "expected" and "actual" output are different in the way that the image is converted to pure black & white. It would be ideal to have this repeatable, but pure black & white images will not be affected.

Animation below toggles between the images contained in the outputs:

animated

disable HHVM, failing

add PHP 5.3

try adding imagemagick

add answer to PECL prompt

add ghostscript install

skip tests that are not bit-for-bit repeatable on Travis CI
@mike42 mike42 merged commit 6792f4b into development Oct 29, 2017
@mike42 mike42 deleted the 396-remove-broken-build-steps branch March 12, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant