Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SMB2 as default highest allowed protocol #488

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

0x6B386F
Copy link
Contributor

Fixes #179

@mike42
Copy link
Owner

mike42 commented Mar 8, 2018

@1dal - thanks for writing this pull request.

I don't have a post-Windows 7 setup to test that this resolves #179, but the code's fine, and I'm planning to merge for the next release.

@mike42 mike42 merged commit 3509f77 into mike42:development Mar 12, 2018
@0x6B386F 0x6B386F deleted the feature/better-smb-support branch March 12, 2018 23:08
@mike42 mike42 mentioned this pull request Mar 13, 2018
@boudafc
Copy link

boudafc commented May 22, 2018

Hello, I have made a test on Windows 10, it seems doesn't work:
Failed to print. Command "smbclient '//xxx.xxx.xxx.xxx/oxhoo_tp50' -c 'print -' -N -m SMB2" failed with exit code 1: WARNING: The "syslog" option is deprecatedNT_STATUS_ACCESS_DENIED opening remote file stdin-4423
I could not do more tests for now because it is on production computer but by removing "-m SMB2" it prints again.
However I could try to do more tests if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants