-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --interval parameter to specify the polling interval for directory/file changes. #84
Conversation
…ory/file changes.
I like this. Can you please rebase and also add this to the Readme? |
Sorry. I did make an update to the readme! For some reason it wasn't committed. |
I'm on holiday for 2 weeks now. I'll have to commit when I'm back in the office. |
Readme is updated. |
Before this is merged, can we set a faster default? The default This is why |
@@ -24,6 +24,9 @@ if (argLen > 1) { | |||
} | |||
|
|||
var waitTime = Number(argv.wait || argv.w) | |||
if (argv.interval || argv.i) { | |||
watchTreeOpts.interval = Number(argv.interval || argv.i) * 1000.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested default of 0.1s (node default is 5.007s!):
watchTreeOpts.interval = Number(argv.interval || argv.i || 0.1) * 1000.0;
Is this project maintained / will this PR be merged soon? I am willing to duplicate the branch and update it if so. Would love to have this improvement added. |
There are other libs that are super at file watching in terms of performance and cleanup. It may be worth considering a move to |
Feel free to fork and update my repo. I'll merge your changes. I have no idea if/when this PR will be merged back to main repo. |
Thanks @ashleydavis @mikeal do you know the status of this repo? |
I am in complete agreement, I'll add anyone with a notable change as a committer, just give me a list :) |
Starter list:
😄 EDIT What i'm proposing to do is review issues, review PRs, ensure tests and sanity, and run any thing by you before merging. I'll thoroughly annotate stuff for you as well. Note, I'm a trusted contributor to https://github.com/shelljs and you can see my other work on my profile. Most of it is in orgs I belong to. |
+1 |
@mikeal not exactly sure what is meant by this. I use watch all over the place but the 5s default watch time is killing me. I'm fully willing and able to address the stale issues and PRs on this repo if you're willing to add me. If this project is not going to add collaborators and also not address issues/pulls please let us know so we can move on. Would much rather keep things here if possible. cc @finnp |
No description provided.