Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DESTDIR #7

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Use DESTDIR #7

merged 1 commit into from
Jul 22, 2021

Conversation

hifiberry
Copy link
Contributor

install-exec-hook does not use DESTDIR which breaks installation in build environments that install in a separate directory (e.g. all cross-compiling environments)

@mikebrady mikebrady merged commit 827e624 into mikebrady:main Jul 22, 2021
@mikebrady
Copy link
Owner

Many thanks for this. I might make a further change to is, a la Shairport Sync, to comply with this, but this is great. (Also, I'm a fan of HiFiBerry stuff.)

@hifiberry
Copy link
Contributor Author

A "nicer" installation of the nqptp header files would also be good. The current implementation that looks for it in ../pqptp also doesn't work well in all environments, but for now I found some hack around this ;-)

@hifiberry
Copy link
Contributor Author

BTW: We're big fans of shairport-sync here :-) Hope to get this working for a test here soon...

@hifiberry hifiberry mentioned this pull request Jul 22, 2021
@mikebrady
Copy link
Owner

A "nicer" installation of the nqptp header files would also be good. The current implementation that looks for it in ../pqptp also doesn't work well in all environments, but for now I found some hack around this ;-)

Yeah, that was done simply for [my] convenience. I'll fix it.

@mikebrady
Copy link
Owner

@hifiberry, I [believe I have] fixed that problem you referred to above. Also, I added a ./configure flag for issue #6. Overkill for you, certainly, but just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants