Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Non interactive login method #2

Merged
merged 1 commit into from
May 4, 2015

Conversation

paulgillard
Copy link
Contributor

Hi Mike,

I'm interested in using this gem too. I've added the non-interactive login method described here (https://api.developer.betfair.com/services/webapps/docs/display/1smk3cen4v3lu3yomq5qye0ni/Non-Interactive+%28bot%29+login). Let me know what you think and if you're happy to merge it. Any changes, thoughts or comments gratefully received.

Thanks,
Paul

Also refactored some code shared between #interactive_login and #non_interactive_login methods. Although it's possible more could be done in future.
@mikecmpbll
Copy link
Owner

Awesome, been meaning to have a look at doing this as, like you say, it's strongly recommended over the basic interactive type -- so you saved me a bunch of time on that front, thanks :)

Will merge now and push v0.2.0 to rubygems.

mikecmpbll added a commit that referenced this pull request May 4, 2015
@mikecmpbll mikecmpbll merged commit 18fccd0 into mikecmpbll:master May 4, 2015
@paulgillard paulgillard deleted the non-interactive-login branch May 6, 2015 12:26
@mikecmpbll mikecmpbll mentioned this pull request Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants