torque script PBS directive error

[ircwaves]

Interesting project. In doing a quick test-drive, I've hit a PBS directive error. It might be a config error or even a torque version mismatch, but fyrd.get_cluster_environment() does return 'torque'. mem gets the complaint, but I believe walltime also needs to be prefixed by -l in the job script.

>>> j = fyrd.Job('ls ', ['.'])
>>> j.submit()
20161129 17:28:48.344 | WARNING --> Command qsub /home/icooke/ls.0.1493c48f.cluster.qsub failed with code 1, retrying.
20161129 17:28:49.348 | WARNING --> Command qsub /home/icooke/ls.0.1493c48f.cluster.qsub failed with code 1, retrying.
20161129 17:28:50.352 | WARNING --> Command qsub /home/icooke/ls.0.1493c48f.cluster.qsub failed with code 1, retrying.
20161129 17:28:51.359 | WARNING --> Command qsub /home/icooke/ls.0.1493c48f.cluster.qsub failed with code 1, retrying.
20161129 17:28:52.364 | CRITICAL --> qsub failed with code 1
-----------------------------------> stdout: 
-----------------------------------> stderr: qsub: directive error: mem=4000MB

And the script file

$ cat /home/icooke/ls.0.1493c48f.cluster.qsub
#!/bin/bash
#PBS -l nodes=1:ppn=1
#PBS mem=4000MB
#PBS -q myqueue
#PBS -e /home/icooke/ls.0.1493c48f.cluster.err
#PBS -o /home/icooke/ls.0.1493c48f.cluster.out
#PBS walltime=04:00:00
mkdir -p $LOCAL_SCRATCH > /dev/null 2>/dev/null
cd /home/icooke
date +'%y-%m-%d-%H:%M:%S'
echo "Running ls.0.1493c48f"
ls .
exitcode=$?
echo Done
date +'%y-%m-%d-%H:%M:%S'
if [[ $exitcode != 0 ]]; then
    echo Exited with code: $exitcode >&2
fi

[MikeDacre]

Thank you @ircwaves, that is definitely a bug, I am surprised I missed something so obvious. Fixing it now.

[MikeDacre]

OK, fixed in dev, now, I will merge it into master tomorrow once all the tests pass.

[ircwaves]

Muy bueno. Good luck with everything on your road to the cheeseshop.

[MikeDacre]

Now fixed in master also, I will release another beta next week and it will be included there. Thanks again @ircwaves.