Fixes issue mikedewar/d3py#23 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem by allowing users to go into non-interactive mode
(endabled by default). One problem this fix has made apparent is that
__del__ is not what we want to cleanup files: the reference count could
be at zero even if we have stale files lying around!
One solution would be to use __enter__ and __exit__ and require the user
to create a figure object with the `with` statement:
with Figure() as fig:
...do stuff with fig...
ideas?
This was referenced Feb 16, 2012
Closed
|
Hey I'm going to raise an issue over the del thing and then come back and make this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem by allowing users to go into non-interactive mode
(endabled by default). One problem this fix has made apparent is that
del is not what we want to cleanup files: the reference count could
be at zero even if we have stale files lying around!
One solution would be to use enter and exit and require the user
to create a figure object with the
withstatement:with Figure() as fig:
...do stuff with fig...
ideas?