Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid output for jed 1.x and ja-JP pluralization #57

Closed
jknight12882 opened this issue Oct 8, 2016 · 3 comments · Fixed by #58
Closed

Invalid output for jed 1.x and ja-JP pluralization #57

jknight12882 opened this issue Oct 8, 2016 · 3 comments · Fixed by #58

Comments

@jknight12882
Copy link

jknight12882 commented Oct 8, 2016

Using 0.4.4. Entry in the .po file

msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2016-10-07 15:13-0700\n"
"PO-Revision-Date: 2016-10-07 14:35-0700\n"
"Last-Translator: \n"
"Language-Team: \n"
"Language: ja_JP\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"X-Generator: Poedit 1.8.9\n"
"X-Poedit-Basepath: .\n"
"Plural-Forms: nplurals=1; plural=0;\n"

#: dist/containers/Search.js:96
#, c-format
msgid "For %s person starting at %s"
msgid_plural "For %s people starting at %s"
msgstr[0] "For %1$s people starting at %2$s"

Json output:

        "For %s person starting at %s": [
            [
               "For %1$s people starting at %2$s"
            ]
         ],

French for example looks like this

        "For %s person starting at %s": [
            "For %1$s person starting at %2$s",
            "For %1$s people starting at %2$s"
         ],
@mikeedwards
Copy link
Owner

@jknight12882 if you can, would you mind seeing if the latest fix I added resolves your issue? If so, I'll make a new release and push to npm.
Thanks!

@jknight12882
Copy link
Author

@mikeedwards Yup, commit 3c45ebf seems to have resolved the issue

@ghost
Copy link

ghost commented Oct 11, 2016

@mikeedwards Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants