Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Menu Height is cut off on iPhone 6 #204

Open
cblaze22 opened this issue Nov 7, 2015 · 5 comments
Open

Side Menu Height is cut off on iPhone 6 #204

cblaze22 opened this issue Nov 7, 2015 · 5 comments

Comments

@cblaze22
Copy link

cblaze22 commented Nov 7, 2015

For some reason the side menu doesnt expand 100% the heigh on iPhone 6 simulator. Is there something I need to do? The menu is being cut off as it seems like there is a fixed height or something on it. It is also being pushed up on first view as you can see in the status bar.

simulator screen shot nov 6 2015 10 48 02 pm

@nobu417
Copy link

nobu417 commented Jan 6, 2016

I've found a quick solution. This is not good solution but it works.

Inside the function called "setLeftSideMenuFrameToClosedPosition", replace line below

CGRect leftFrame = [self.leftMenuViewController view].frame;

to the code below.

CGRect leftFrame = [self.centerViewController view].frame;

I'm not sure the detail but the rect value of leftMenuViewController detected automatically doesn't work well on devices newer than 5s such iPhone 6, 6 Plus and the other newers. But the rect value of centerViewController detected works well on them.

@cblaze22
Copy link
Author

cblaze22 commented Jan 6, 2016

Why would you consider this a bad solution?

@nobu417
Copy link

nobu417 commented Jan 7, 2016

Because basically leftFrame and centerView are not same stuff even the size both calculated are same.

@cblaze22
Copy link
Author

That actually works very well, no complaints here. Probably should update the code on here with that and the right menu. My center content is always the size of the screen though.

@xxfenxx
Copy link

xxfenxx commented Jan 28, 2016

I also found that side menu doesnt expand 100% the heigh on iPhone 6 simulator with the issue is the view.size.height less 20 pix

in function "- (void)setCenterViewController:(UIViewController *)centerViewController"

replace :
[((UIViewController *)_centerViewController) view].frame = (CGRect){.origin = origin, .size=centerViewController.view.frame.size};
with :
[((UIViewController *)_centerViewController) view].frame = self.leftMenuViewController.view.frame;

can solve this!

simulator screen shot 2016 1 28 12 23 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants