-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: expose 'createImage' so can be used w/ other filesystems #258
Comments
Would it help to add a I'd rather prefer to have the same interface on both classes, Pdf and Image. |
It’s not text data though, it’s binary data. But yes as long as there’s a way to retrieve the raw binary data, that would work. However I don’t need the |
@edalzell I've just pushed a change to master where You don't have to worry about temporary files. This is handled by our php-tmpfile class which will auto-delete any temporary files - unless there was an error. |
So awesome, thanks! I'll update my code when you release so that my customer can get the right code when he installs my addon. |
I've released 2.3.0 containing this change. Thanks for the suggestion! |
I'm trying to use this great library in a CMS that uses PHP League's Flysystem, so I need to be able to get the contents of the created image to pass into something like this
$filesystem->write($path, file_get_contents($temp_path));
To do this, all that needs to happen is to change
createImage
fromprotected
orpublic
.The text was updated successfully, but these errors were encountered: