Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle callbacks with more than two arguments #9

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Correctly handle callbacks with more than two arguments #9

merged 1 commit into from
Jul 6, 2015

Conversation

pgaubatz
Copy link
Contributor

@pgaubatz pgaubatz commented Jul 6, 2015

If the promisified function calls the callback with more than two arguments (e.g., cb(null, 1, 2, 3)) then the result of the Promise should be an array (e.g., [1, 2, 3]).

mikehall314 added a commit that referenced this pull request Jul 6, 2015
Correctly handle callbacks with more than two arguments
@mikehall314 mikehall314 merged commit 3d8966c into mikehall314:master Jul 6, 2015
@mikehall314
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants