feat(notifee): Event listeners with M1 support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
reviewed
Jan 31, 2021
| cd ios && pod install --repo-update && cd .. | ||
| if [ "$(uname -m)" == "arm64" ]; then | ||
| echo "Installing pods with prefix arch -arch x86_64" | ||
| cd ios && arch -arch x86_64 pod install && cd .. |
There was a problem hiding this comment.
fascinating! would have never known to that - flipper disable I knew but obviously wasn't implemented - but this is some subtle magic. Thanks
There was a problem hiding this comment.
thanks Mike! Your script is great. It was fun to try it out, very handy and useful!
mikehardy
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
notifee-demo.shwith a couple of things:arch -arch x86_64beforepod install. Not needed if developer has installffiglobally but it helps to have it there to ensure it works (Got error while trying pod install CocoaPods/CocoaPods#10220).--repo-updateAdded event listeners for
onForegroundEventandonBackgroundEvent