Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Client login logic #63

Closed
nazar opened this issue Feb 6, 2018 · 0 comments · Fixed by #83
Closed

Cleanup Client login logic #63

nazar opened this issue Feb 6, 2018 · 0 comments · Fixed by #83

Comments

@nazar
Copy link
Collaborator

nazar commented Feb 6, 2018

Related to #43.

Tasks

  1. Refactor the top level client login, callback and almost-finished routes into a single login view with the callback and almost-finished as sub-routes.

  2. Refactor this block of code to only be called in the new login/callback component as currently the Promise in the block of code never fulfils as the lock.on events only trigger durring the auth0 callback. Instead attempt to use webAuth.checkSession to auto login the user if their auth0 session is still active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant