Fix bug in logError() when instance of \Error is thrown
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PHP7 internal php errors are thrown as instances of `\Error` which is not an instance of `\Exception`. Both `\Error` and `\Exception` are instance of `\Throwable`. As `\Throwable` is not available in PHP<7 there is no way to type hint for both \Error and \Exception if you want to be compatible with PHP<7.
|
That's true, thanks, Erik! |
|
Thanks! Could you make a new release :)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP7 internal php errors are thrown as instances of
\Errorwhich is notan instance of
\Exception. Both\Errorand\Exceptionare instance of\Throwable.As
\Throwableis not available in PHP<7 there is no way to type hint for both\Error and \Exception if you want to be compatible with PHP<7.