Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strategy does not pass algorithms option #25

Closed
newmanw opened this issue Aug 23, 2015 · 0 comments · Fixed by #26
Closed

strategy does not pass algorithms option #25

newmanw opened this issue Aug 23, 2015 · 0 comments · Fixed by #26

Comments

@newmanw
Copy link

newmanw commented Aug 23, 2015

Add option for algorithms such that it can be passed through to jwt.verify.

More info on why this is important:
https://auth0.com/blog/2015/03/31/critical-vulnerabilities-in-json-web-token-libraries/
newmanw pushed a commit to newmanw/passport-jwt that referenced this issue Aug 23, 2015
Add algorithms option
69bb170 
add algorithms option that is passed through to jwt.verify to verify jwt algorithm is
in this 'whitelist' array.

fixes mikenicholson#25
@newmanw newmanw mentioned this issue Aug 23, 2015
Merged
mikenicholson added a commit that referenced this issue Aug 24, 2015
@mikenicholson
Merge pull request #26 from newmanw/bugfix-25
0a883e2 
Add algorithms option. Fixes #25.
mikenicholson added a commit that referenced this issue Sep 17, 2015
@mikenicholson
[Updated] v1.1.1 -> v1.2.1
c88c3a9 
    New Features:
        #25 Added algorithms option to allow user to specify
            allowabe JWT signing algorithms.
        #13 Add ignoreExpiration option to allow user to skip
            validation of token's expiration date.

    Bug Fixes:
        #30 Fixed typos in unit test strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add algorithms option newmanw/passport-jwt
1 participant
@newmanw