-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style problem with 2.8.1 and AppCompat lib 22.1.0 on android 4.0.3 #252
Comments
@wildfatduck i'm not sure. i don't use app:theme in the MaterialDrawer do you have it somewhere? |
@wildfatduck i think i found the issue. it's fixed in the next version please try v2.8.2 |
With v2.8.2 "app:theme is now deprecated. Please move to using android:theme instead." messages are gone, but problem with fonts color is still there. I fixed this by using Base.Theme.AppCompat.Light.DarkActionBar as parent and added @style/MaterialDrawer.DrawerArrowStyle for white color of humburger icon. |
yeah this will be fixed in the next version. it will also be required to set a theme for the toolbar then |
Hello, <style name="MaterialDrawerTheme.Light.DarkToolbar.TranslucentStatus.Background" parent="MaterialDrawerTheme.ActionBar.TranslucentStatus">
<item name="android:windowBackground">@color/material_drawer_primary</item>
<item name="android:textColorPrimary">@color/text_primary</item>
<item name="android:textColor">@color/text_secondary</item>
</style> AS this is a lightTheme, my textColorPrimary is a "grey" color, however when I apply the following style="@style/Base.TextAppearance.AppCompat.Body2" to a textview, the thet is white instead of grey (the body2 uses the text_primary) Thank you! |
@gpulido there will be an update with an updated theme soon. this will then require you to set the theme for the toolbar too (as advised from the android team) |
@mikepenz Thank you for the info. I guess that you are refering to an "material drawer" update, aren't you? |
@gpulido have you details about the changelog of 22.1.1 (not 22.1.0) there will be an update soon :D. will be v2.9.0 because there will be a little bit work. (defining the toolbar style on yourown) |
@mikepenz Take a look here: |
v2.9.0 solved the issue, amazing work as always @mikepenz |
@gpulido awesome ;) |
If I'am using MaterialDrawerTheme.Light.DarkToolbar.ActionBar as parent style, I have problems with fonts color, if this colors was inherited from theme (they just white) and in logs a lot of messages:
"app:theme is now deprecated. Please move to using android:theme instead."
With MaterialDrawerTheme.Light as parent there is no such problems, but humburger icon is black, I need white :)
On 5.1 everything is ok.
The text was updated successfully, but these errors were encountered: