-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test MaterialDrawer v5.0.0 with FastAdapter, fitsSystemWindows #920
Comments
I'm getting |
@fergalmoran oh sorry. missed that you have to add the snapshots repo so it can find it: |
new snapshot |
compile('com.mikepenz:materialdrawer:5.0.0.fastAdapter.b8-SNAPSHOT@aar') {
transitive = true
} |
compile('com.mikepenz:materialdrawer:5.0.0.fastAdapter.b9-SNAPSHOT@aar') {
transitive = true
} |
compile('com.mikepenz:materialdrawer:5.0.0.fastAdapter.b10-SNAPSHOT@aar') {
transitive = true
} |
compile('com.mikepenz:materialdrawer:5.0.0.fastAdapter.b12-SNAPSHOT@aar') {
transitive = true
} |
compile('com.mikepenz:materialdrawer:5.0.0.fastAdapter.b14-SNAPSHOT@aar') {
transitive = true
} |
Ok i just pushed a new beta for the MaterialDrawer. This one contains huge changes how the drawer is drawn behind the
Use the system, don’t fight it I made this descision after reading the following article, which is may interesting for you too: I already updated the sample containing all necessary changes
|
@mikepenz: With 5.0.0.b21-SNAPSHOT, it doesn’t seem to support showing the drawer below the status bar yet. (And the issues with 4.6.4 are obvious, regarding KeyboardUtil and its interaction with SlidingUpPanel, etc) |
@justjanne b21 starts to use the Showing below the the |
I’m on b21, using drawerLeft = new DrawerBuilder()
.withActivity(this)
.withToolbar(toolbar)
.withAccountHeader(accountHeader)
.withSavedInstance(savedInstanceState)
.withTranslucentStatusBar(true)
.build(); And get this result on LOLLIPOP: http://i.imgur.com/7JOJetM.png |
@justjanne your theme? |
@justjanne you either use a theme which has the |
@justjanne no problem ;) |
@justjanne Material-Dialogs is from aiden not me :D |
compile('com.mikepenz:materialdrawer:5.0.0.b23-SNAPSHOT@aar') {
transitive = true
} |
compile('com.mikepenz:materialdrawer:5.0.0.b24-SNAPSHOT@aar') {
transitive = true
} |
I changed to use this new library but I see that the drawer is the same as always, what changes exactly provides ? |
v5.0.0 has many internal changes, uses a new adapter internally, provides expandable item functionality, .... It now also do not add the FULLSCREEN flag anymore, it will now use the system internal mechanisms as far as possible. depending on no more colored statusbar on API < 21 |
compile('com.mikepenz:materialdrawer:5.0.0.b25-SNAPSHOT@aar') {
transitive = true
} |
Works great so far, but I noticed one minor thing: If a user opens the App for the first time, the Drawer is supposed to stay at the screen until used or swiped away. That doens't work with 5.0 for me whereas it does work with 4.6.4. With 5.0 the Drawer shortly shows up and then closes itself at first start. |
@rubengees just tried it in the sample. The drawer opens and it stays opened. Perhaps somehting on your side triggers this? |
Hmm okay very weird, I will have a look. |
compile('com.mikepenz:materialdrawer:5.0.0.b26-SNAPSHOT@aar') {
transitive = true
} |
compile('com.mikepenz:materialdrawer:5.0.0.b27-SNAPSHOT@aar') {
transitive = true
} |
v5.0.1 is realeased. This issue is now "solved" |
v5.0.0 of the MaterialDrawer will internally switch to the
FastAdapter
which provides a highly flexible and performant Adapter implementation which allows a flexible setting of new Item's as the MaterialDrawer did it in the past.This is a huge step as it will bring new features in the future.
Changes for this are currently on the FastAdapter branch (https://github.com/mikepenz/MaterialDrawer/tree/feature/FastAdapter)
Via this dependency:
As this is just a SNAPSHOT at the moment it is only available on the SNAPSHOTS repo of maven central. You can add it like done here:
https://github.com/mikepenz/MaterialDrawer/blob/feature/FastAdapter/build.gradle#L17
Please test and report back
The text was updated successfully, but these errors were encountered: