Use browscap-php to detect JavaScript supported version #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, after going down this rabbit hole for a couple of hours, I don't think the browscap function detect which version of JavaScript are supported by a browser - it just gives true or false if JavaScript is detected at all! And it does it by parsing the User Agent - see https://browscap.org/ua-lookup. |
|
Thanks for spending the time to investigate this. As far as I can tell, it's mainly intended to replace/enhance the standard PHP get_browser() function, so it wouldn't go into much detail about the WebKit version etc. indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #62 for background.
Currently COPS is searching the user agent string to determine which browsers to send to server-side rendering.
A better approach might be to check browser capabilities, which can be done in a couple of ways:
JavaScript client side check
JavaScript run inside a <script nomodule> tag will be ignored by browsers that support ES6 and up.
PHP server side check
The browscap-php package should allow checking the version of JavaScript that is supported by the browser through . Unfortunately I have yet to figure out how to get browscap-php working. I have managed to get it installed via composer, and used its commands to fetch and convert the browsercap.ini file, but stuck at actually writing code that gets the info. The documentation assumes a lot of knowledge I don't have.
This PR is specifically about getting browscap-php to work.