Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luba sensors pt 4 #16

Merged
merged 16 commits into from
Jul 8, 2024
Merged

Luba sensors pt 4 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e46e25a
Gets fix type
jLynx Jun 3, 2024
bb2d248
Updated credits
jLynx Jun 3, 2024
220aa7a
Added notes on what we are missing
jLynx Jun 3, 2024
f94125f
Fixed compile bug
jLynx Jun 3, 2024
0b130f5
Bumpped version
jLynx Jun 26, 2024
2b242c7
Now refrence pyluba
jLynx Jun 26, 2024
39f0552
Fixed linting
jLynx Jun 26, 2024
843b845
Adding model
jLynx Jun 26, 2024
3dff276
Now shows mower name
jLynx Jun 26, 2024
fa899a4
updated serial number
jLynx Jun 26, 2024
a2e27a9
Updated pyluba
jLynx Jun 26, 2024
08913ec
Updated to get model
jLynx Jun 26, 2024
5d31b32
Updated version
jLynx Jun 27, 2024
8e65a4d
Merge branch 'main' into luba_Sensor_4
jLynx Jun 27, 2024
5817bc1
Merge branch 'main' into luba_Sensor_4
jLynx Jul 8, 2024
e6b2ff5
Commented out version for now
jLynx Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion custom_components/mammotion/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

from .const import DOMAIN
from .coordinator import MammotionDataUpdateCoordinator
from pyluba.utility.device_type import DeviceType

_LOGGER = logging.getLogger(__name__)

Expand All @@ -25,7 +26,10 @@ def __init__(
self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, device_name)},
manufacturer="Mammotion",
serial_number=coordinator.device.luba_msg.net.toapp_wifi_iot_status.productkey,
serial_number=device_name.split('-', 1)[-1],
# ToDo: To add in once betterproto is fixed
# sw_version=coordinator.device.luba_msg.net.toapp_devinfo_resp.resp_ids.get(0, {}).get('info', "Loading..."),
model=DeviceType.value_of_str(device_name, coordinator.device.luba_msg.net.toapp_wifi_iot_status.productkey).get_model(),
name=device_name,
suggested_area="Garden",
)
Expand Down
6 changes: 5 additions & 1 deletion custom_components/mammotion/lawn_mower.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from homeassistant.helpers.typing import ConfigType
from pyluba.mammotion.devices.luba import has_field
from pyluba.utility.constant.device_constant import WorkMode
from pyluba.utility.device_type import DeviceType

from .const import DOMAIN
from .coordinator import MammotionDataUpdateCoordinator
Expand Down Expand Up @@ -74,7 +75,10 @@ def __init__(
self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, device_name)},
manufacturer="Mammotion",
serial_number=coordinator.device.luba_msg.net.toapp_wifi_iot_status.productkey,
serial_number=device_name.split('-', 1)[-1],
# ToDo: To add in once betterproto is fixed
# sw_version=coordinator.device.luba_msg.net.toapp_devinfo_resp.resp_ids.get(0, {}).get('info', "Loading..."),
model=DeviceType.value_of_str(device_name, coordinator.device.luba_msg.net.toapp_wifi_iot_status.productkey).get_model(),
name=device_name,
suggested_area="Garden",
)
Expand Down
1 change: 0 additions & 1 deletion custom_components/mammotion/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ class MammotionSensorEntityDescription(SensorEntityDescription):
MammotionSensorEntityDescription(
key="position_mode",
name="RTK Connection",
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.ENUM,
native_unit_of_measurement=None,
value_fn=lambda mower_data: str(RTKStatus.from_value(mower_data.sys.toapp_report_data.rtk.status)), # Note: This will not work for Luba2 & Yuka. Only for Luba1
Expand Down