Add option to disable tls 1.2 #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinji257
force-pushed
the
patch-1
branch
3 times, most recently
from
91fa3fb
to
f86c832
Compare
Fix for Patreon Cloudflare issues by having only TLS v1.3 or higher establish HTTPS connections
This now allows you to disable it on a per-host or global basis. Add disabletls12 as a config option either under extractor.(host) or just under extractor. Option is false by default.
Example:
"patreon":
{
"disabletls12": true,
"cookies": {
"session_id": "X"
}
}
|
Updated PR to make the setting configurable. You can add disabletls12 to either global extractor configuration or only to a specific extractor (if you wish) to disable TLS 1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Patreon Cloudflare issues by having only TLS v1.3 or higher establish HTTPS connections
This is based on the fact that there is another downloader that works fine and they indicate Cloudflare is triggered when TLS lower than 1.3 is used for it. As of right now I tested on source and verified to trigger then made this one edit and it worked immediately after. At this time can anyone else validate the change and see if Patreon starts working for you as well? It is possible that once a TLSv1.3 connection is made from the client it stops triggering Cloudflare for a while as the normal version is working as well right now and it hasn't worked for quite a while.