Fix incompatibility with scipy 1.14.0 and numpy 2.0

[schuenke]

As described in #142, several changes in the scipy and numpy packages lead to errors in sigpy.

I tried to fix them so that all tests pass now, but I am not a sigpy user myself and can't guarantee that all changes in the function calls, especially the introduction of the kwarg "weight", are actually correct. Would be great if someone could confirm that the one character variable w is supposed to be a weight (although from the scipy changelog I am quite sure that this is the case 😁 )

The rest should be fine.

closes #142

[jweine]

Maybe it is worth noting that these changes introduce the minimum requirements of:

• Scipy 1.6.0 (Renaming with backwards compatibility: MAINT: rename trapz and cumtrapz to (cumulative_)trapezoid scipy/scipy#12934), the window namespace seems to preceed 1.6.0 anyway)
• Numpy 1.13 (oldest available reference version including np.inf: https://numpy.org/doc/1.13/reference/generated/numpy.isinf.html#numpy.isinf)

There for in project.toml specifying should be foolproof. However, as these versions are pretty outdated I am not sure if this is absolutely necessary.

[schuenke]

Maybe it is worth noting that these changes introduce the minimum requirements of:

* Scipy 1.6.0 (Renaming with backwards compatibility: [MAINT: rename trapz and cumtrapz to (cumulative_)trapezoid scipy/scipy#12934](https://github.com/scipy/scipy/pull/12934)), the window namespace seems to preceed 1.6.0 anyway)

* Numpy 1.13 (oldest available reference version including `np.inf`: https://numpy.org/doc/1.13/reference/generated/numpy.isinf.html#numpy.isinf)

There for in project.toml specifying should be foolproof. However, as these versions are pretty outdated I am not sure if this is absolutely necessary.

Thanks for checking. Currently, no version numbers are defined in the pyproject.toml at all. Not sure if this is on purpose (if you start it, you need to keep it up to date) or not ?! Maybe one of the maintainers can let me know if I should change it and include it in this PR.

[tito21]

Is anyone still looking at this? I think that is important that sigpy works in a modern python ecosystem.

For my use case this branch is working (I only really use the EspiritCalib)

[frankong]

Will take a look this week. Sorry for the delayFrankOn Aug 13, 2024, at 9:13 AM, Alberto Di Biase ***@***.***> wrote: Is anyone still looking at this? I think that is important that sigpy works in a modern python ecosystem. For my use case this branch is working (I only really use the EspiritCalib) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[gattia]

Just checking this - I went to make a new PR because of the numpy incompatibility, but then saw that its already fixed here but not merged.

[lrlunin]

Please also bump the numpy version to at least >=1.23.5 in conda-forge distribution https://github.com/conda-forge/sigpy-feedstock .

[jtamir]

Straightforward changes, thank you!