-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling modes of image decorator #54
Comments
Have anyone found a good use of the previous tile repeat modes? I have always been a bit confused about them, and think they can be replaced with the new modes: enum TileFitMode
{
FILL, // Tile is stretched to boundaries.
CONTAIN, // Tile is stretched to boundaries, keeping aspect ratio fixed, 'letter-boxed'.
COVER, // Tile is stretched to cover the boundaries, keeping aspect ratio fixed, and clipped.
CENTER, // Tile is centered and never stretched, clipped if too large.
REPEAT, // Tile is repeated by tiling if too large, clipped if too small.
}; I'm also trying to stay consistent here with the CSS object-fit naming. Or maybe it makes more sense with some new keywords for the "center" tiles to say whether they should be fixed (thereby stretching the edges) or stretched (thereby keeping the edges fixed)? And removing the existing repeat modes. |
To be honest, I've never used any of those scaling/repeat modes... |
We now have scaling modes and alignment for the image decorator which I'm quite happy with, see 5ffe4f4. I'm not sure what makes sense for the other tiled decorators, or how they should be specified. |
I consider this resolved. If anyone have any ideas or use cases for the other tiled decorators, then feel free to open a new issue. |
Implement scaling modes for the image decorator, e.g. such as:
Also, consider adding a 'fixed-size' center mode for tiled-horizontal, tiled-vertical, and tiled-box decorators.
See discussion in: #22 (comment)
The text was updated successfully, but these errors were encountered: