Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LuaPlugin: LuaJit support #387

Merged
merged 2 commits into from
Feb 9, 2023
Merged

LuaPlugin: LuaJit support #387

merged 2 commits into from
Feb 9, 2023

Conversation

mrianura
Copy link
Contributor

@mrianura mrianura commented Dec 7, 2022 •
edited
Loading

LuaJit support

@mikke89 mikke89 added Lua Lua binding issues build Build system and compilation labels Dec 7, 2022
mikke89
mikke89 reviewed Dec 7, 2022
View reviewed changes
Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Are you able to add a test for this to the GitHub action workflow? Either the Ubuntu or the vcpkg test for example?

CMakeLists.txt Outdated Show resolved Hide resolved
@mrianura
Copy link
Contributor Author

mrianura commented Dec 8, 2022

Thanks for the review, i will fix mentioned points

@mikke89
Copy link
Owner

mikke89 commented Dec 30, 2022

Hey, any update on this?

@mrianura
Copy link
Contributor Author

mrianura commented Jan 3, 2023

hello, Yes I'm planning to fix the issue this week, I was just overloaded with everything around holidays and new year eve, sorru

@mikke89
Copy link
Owner

mikke89 commented Jan 5, 2023

I understand, no worries, looking forward to seeing those changes.

@mrianura
Copy link
Contributor Author

mrianura commented Feb 9, 2023

I've had a look on requested changes, but I'm a bit lost with adding tests to this. Could You pelase support here a little bit ?

@mikke89
Copy link
Owner

mikke89 commented Feb 9, 2023

No problem, I'll take a look at it.

@mikke89 mikke89 merged commit d411bf3 into mikke89:master Feb 9, 2023
@mikke89
Copy link
Owner

mikke89 commented Feb 9, 2023

Everything seems to be working well now, I tested it locally too. Thanks for finishing up this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikke89 mikke89 mikke89 left review comments

Assignees
No one assigned
Labels
build Build system and compilation Lua Lua binding issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrianura @mikke89 @uccold