Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub commands #3

Closed
mikn opened this issue Jun 17, 2019 · 0 comments · Fixed by #12
Closed

pubsub commands #3

mikn opened this issue Jun 17, 2019 · 0 comments · Fixed by #12
Labels
enhancement New feature or request
Milestone
0.1.0

Comments

@mikn
Copy link
Owner

mikn commented Jun 17, 2019 •
edited
Loading

https://redis.io/topics/pubsub
@mikn mikn added this to the 0.1.0 milestone Nov 1, 2019
@mikn mikn linked a pull request May 9, 2020 that will close this issue
Pubsub implementation #12
Merged
@mikn mikn added the enhancement New feature or request label May 23, 2020
@mikn mikn closed this as completed in #12 Aug 24, 2020
mikn added a commit that referenced this issue Aug 24, 2020
@mikn
Merge pull request #12 from mikn/pubsub
a18dfa7 
Pubsub implementation which includes switching writing over to use `bufio.Writer` and reading over to use `bufio.Reader`. It became too cumbersome to effectively manipulate the byte buffer, especially in the pubsub scenario. Some of these changes are more first versions and we're not seeing amazing performance numbers for pubsub right now (but zero allocs!). I have often opted for safety rather than speed with the use of unbuffered channels in many cases.

There are still some issues, such as that `.String()` `.Bytes()` and the `Scanner` implementation for `Result` doesn't support reading longer replies than buffer size yet. I will file that as a separate issue. You can use `io.Writer` still passed in to `Result` to read out larger values.

It addresses #3 and #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Pubsub implementation mikn/greddis
1 participant
@mikn