feat(core): allow inferring populate hint from filter via populate: ['$infer']
#4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
force-pushed
the
populate-infer
branch
from
39b163e
to
eb5b047
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4939 +/- ##
=======================================
Coverage 99.42% 99.43%
=======================================
Files 222 222
Lines 16037 16052 +15
Branches 3850 3851 +1
=======================================
+ Hits 15945 15961 +16
+ Misses 89 88 -1
Partials 3 3 ☔ View full report in Codecov by Sentry. |
B4nan
force-pushed
the
populate-infer
branch
2 times, most recently
from
7a15ba6
to
19f0645
Compare
…['$infer']`
If you want to automatically select all the relations that are part of your filter query, use `populate: ['$infer']`:
```ts
// this will populate all the books and their authors, all via a single query
const tags = await em.find(BookTag, {
books: { author: { name: '...' } },
}, {
populate: ['$infer'],
});
```
> This will always use joined strategy as we already have the relations joined because they are in the filter.
Closes #1309
B4nan
force-pushed
the
populate-infer
branch
from
19f0645
to
080216a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to automatically select all the relations that are part of your filter query, use
populate: ['$infer']:Closes #1309