Don't append :80 to url for port 80 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, thank you! Looking good! Could you rebase your changes and change the base of this PR to I'll do the necessary version increments, merge changes to |
|
Hopefully that should do it for ya! |
|
Thank you very much! |
|
...and released in |
|
👍 🎆 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short: as of Chrome 58.0.3018.3, CSP headers parsing for
wss://*acceptswss://siteas allowed, but does NOT acceptwss:site:80. This tweak removes the unneeded:80and, in doing so, allows the use of livereactload in situations (i.e. Shopify theme design) where the dev doesn't have control over the CSP settings the server sends.