Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 incl PHP7.2+ #150

Merged
merged 4 commits into from
Nov 10, 2022
Merged

PHP8 incl PHP7.2+ #150

merged 4 commits into from
Nov 10, 2022

Conversation

dereuromark
Copy link
Collaborator

@dereuromark dereuromark commented Sep 18, 2020

Resolves #148

Requires #149 to be released first as last minor of PHP5 support.

WIP for a while
we can add more things here.

Since we do make a major here, we can add typehints.

TODO:

  • unskip php8 run in travis matrix.
  • Add strict typehints (param and return)
  • Cleanup API? Is there anything that could be done in such a major - or deprecations to be removed?
  • Fix getSmilies() to getSmileys()

@milesj
Copy link
Owner

milesj commented Sep 18, 2020

Feel free to migrate this to GitHub Actions/CI if that works better.

@dereuromark
Copy link
Collaborator Author

It looks more like sth PHPUnit9+ related for some reason..

@dereuromark
Copy link
Collaborator Author

Yeah, now its green :) PHP 8 passes.

There was 1 warning:
1) Decoda\DecodaTest::testCustomConfigPath
The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageMatches() instead.

@dereuromark dereuromark mentioned this pull request Sep 18, 2020
@dereuromark
Copy link
Collaborator Author

Should we merge and release a new minor if all is BC?

@milesj
Copy link
Owner

milesj commented Nov 10, 2022

@dereuromark Go for it!

@dereuromark dereuromark merged commit 8c8fbaf into master Nov 10, 2022
@dereuromark dereuromark deleted the php8 branch November 10, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major major (BC break)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP7.2+
2 participants