Python3 signature #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this modification, the main functionality should be portable to python2. The __signature__ will only be retrieved and used if the platform has support for this feature.
Sorry for the extra top level folder. It seems nosetests has no real support for excluding individual tests based on runtime version. There are the --py3where and --where options that could be used. Though, with one of these enabled the entire test is run from the specified subdirectory. Which means that all top level content has to be symlinked in order to provide a valid runtime without the module installed.
|
Thanks for taking care of this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3-only support for conserving signatures. That means default-arguments will be usable.
This is a rather minimalistic approach that introduces no extra dependencies on third-party libraries and does not break python2 compatibility.