Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emacs interface to Docker #2782

Merged
merged 2 commits into from
Jun 17, 2015
Merged

Add emacs interface to Docker #2782

merged 2 commits into from
Jun 17, 2015

Conversation

Silex
Copy link
Contributor

@Silex Silex commented May 18, 2015

Hello,

Don't merge this yet

I created this PR as a motivation booster for me to finish my package https://github.com/Silex/docker.el :) And also to notice the world that this is a work in progress, and maybe get contributors.

I'm currently discussing with @emacs-pe wether the current docker.el package should be renamed to docker-tramp, see emacs-pe/docker-tramp.el#1.

Several things needs to be done:

  • Get settled on the name of this package, maybe renaming it.
  • Make a basic implementation for containers manipulation.
  • Finish the various images tasks (right now only "rmi" works).

@purcell: I'll summon you when all these tasks are done for your little review magic :)

@Silex
Copy link
Contributor Author

Silex commented Jun 16, 2015

@purcell: I was reddited so this boosts me into making a basic implementation, just to notify you that you'd soon be able to do your quick review magic :)

@purcell
Copy link
Member

purcell commented Jun 16, 2015

docker.el requires docker-containers, which I don't see anywhere.

@Silex
Copy link
Contributor Author

Silex commented Jun 17, 2015

purcell: yeah it's in the containers branch, PEBKAC I'll merge it soon.

@Silex
Copy link
Contributor Author

Silex commented Jun 17, 2015

@purcell: okay, the basic functionnality is there now. Still a lot to improve but at least I think it's MELPA-able. Is the recipe good?

@purcell
Copy link
Member

purcell commented Jun 17, 2015

There's a recipe for a package called docker-api, but in the corresponding repo there isn't a docker-api.el or a docker-api-pkg.el. So that recipe isn't really valid. The other two recipes look fine.

@Silex
Copy link
Contributor Author

Silex commented Jun 17, 2015

Oops, right I forgot about this one. I'll remove it for now, it'll be an extra dependency later on but I can just change the docker-pkg.el for this and make a new PR for the dependency.

Thanks!

@Silex
Copy link
Contributor Author

Silex commented Jun 17, 2015

A'ight, if things looks ok I think you can merge.

purcell added a commit that referenced this pull request Jun 17, 2015
Add emacs interface to Docker
@purcell purcell merged commit 6c74bf8 into melpa:master Jun 17, 2015
@purcell
Copy link
Member

purcell commented Jun 17, 2015

Done, thanks!

@Silex
Copy link
Contributor Author

Silex commented Jun 17, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting action from an upstream maintainer recipes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants