Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for device type 0xC3 (heat pumps) #108

Draft
wants to merge 69 commits into
base: main
Choose a base branch
from
Draft

Add support for device type 0xC3 (heat pumps) #108

wants to merge 69 commits into from

Commits on Mar 6, 2024

  1. Reorganize references in prep for C3 device

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    213a3fa View commit details
    Browse the repository at this point in the history

  2. Add 0xC3 device references

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c290d84 View commit details
    Browse the repository at this point in the history

  3. Add heat pump to device type enum

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    7bbc4c7 View commit details
    Browse the repository at this point in the history

  4. Add some basic types from the reference code

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    99fad71 View commit details
    Browse the repository at this point in the history

  5. Add skeleton device class for Heat pump

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d836656 View commit details
    Browse the repository at this point in the history

  6. Add some basic command classes for querying device state

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f72ee67 View commit details
    Browse the repository at this point in the history

  7. Add basic control command

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cf57532 View commit details
    Browse the repository at this point in the history

  8. Add some skeleton response classes

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0476268 View commit details
    Browse the repository at this point in the history

  9. Use bytearray for payload

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1bdbdb0 View commit details
    Browse the repository at this point in the history

  10. Simplify CRC8 implementation

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    492c52c View commit details
    Browse the repository at this point in the history

  11. Overhaul base command class for C3 device support 

    - Rename from Command to Frame
- Strip message ID and CRC which apparantly are not common to all devices
- Remove payload property and rework tobytes implementation to cascade code from the most derived class to the most super class
    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    28dff33 View commit details
    Browse the repository at this point in the history

  12. Remove ABC from class inheritance. Likely wasn't being used right

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1243dbc View commit details
    Browse the repository at this point in the history

  13. Move Frame checksum validation into class

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    204050f View commit details
    Browse the repository at this point in the history

  14. Flesh out enough response handling to start testing message RX

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b32ecf5 View commit details
    Browse the repository at this point in the history

  15. Add heatpump to device __init__

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    37f0b97 View commit details
    Browse the repository at this point in the history

  16. Rename base_command to frame

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    800e159 View commit details
    Browse the repository at this point in the history

  17. Fix typing for Python 3.8

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    66b038c View commit details
    Browse the repository at this point in the history

  18. Fix Heat pump device type. It's 0xC3 not 0x3C...

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0a14f5c View commit details
    Browse the repository at this point in the history

  19. Remove extra byte of frame length, apparently this differs between 0x… 

    …C3 and 0xAC devices, OR 0xAC devices don't check length
    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e0edf5c View commit details
    Browse the repository at this point in the history

  20. Fix ranges on payload which truncated packet to 0

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cbea092 View commit details
    Browse the repository at this point in the history

  21. Adjust length check on QueryBasicResponse payload

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    55a700c View commit details
    Browse the repository at this point in the history

  22. Add basic testcase for QueryBasicResponse

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8566e65 View commit details
    Browse the repository at this point in the history

  23. Autopep fix

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    aa3407f View commit details
    Browse the repository at this point in the history

  24. Convert temperature types to ints

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6efaaa6 View commit details
    Browse the repository at this point in the history

  25. Handle invalid tank temperature

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    26b622f View commit details
    Browse the repository at this point in the history

  26. Update some todos in QueryBasicResponse

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1586cc1 View commit details
    Browse the repository at this point in the history

  27. Fix zone2 terminal type parsing

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    667717d View commit details
    Browse the repository at this point in the history

  28. Decode room thermostat bits

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e971a4b View commit details
    Browse the repository at this point in the history

  29. Start fleshing out the heat pump device

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8507a26 View commit details
    Browse the repository at this point in the history

  30. Update some basic query response names and comment the original refer… 

    …ence
    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    14ab397 View commit details
    Browse the repository at this point in the history

  31. Apply isort

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    38197ae View commit details
    Browse the repository at this point in the history

  32. Add additional enums

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e443b40 View commit details
    Browse the repository at this point in the history

  33. Add some additional comments to basic query response

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e2ea86c View commit details
    Browse the repository at this point in the history

  34. Tweak ControlBasicCommand

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4083b28 View commit details
    Browse the repository at this point in the history

  35. Adjust some command property names

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    be9bbdf View commit details
    Browse the repository at this point in the history

  36. Flesh out more device properties and add a refresh function to get th… 

    …e state
    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    89df266 View commit details
    Browse the repository at this point in the history

  37. Add command and response for Unit Parameters which contains some usef… 

    …ul temperature sensors
    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    a165617 View commit details
    Browse the repository at this point in the history

  38. Fix silly typo in update_state

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9f93982 View commit details
    Browse the repository at this point in the history

  39. Add minimal testcase for device state updates

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1846a2e View commit details
    Browse the repository at this point in the history

  40. Parse Unit Parameters responses

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    70384aa View commit details
    Browse the repository at this point in the history

  41. Query and process unit parameters

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    342e35b View commit details
    Browse the repository at this point in the history

  42. Add HMI query type

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6dd49a2 View commit details
    Browse the repository at this point in the history

  43. Minor tweaks to zone parsing

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e10645d View commit details
    Browse the repository at this point in the history

  44. Add properties for DHW

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4c48e82 View commit details
    Browse the repository at this point in the history

  45. Disable UnitParameters query

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    acc9e82 View commit details
    Browse the repository at this point in the history

  46. Rename FrameType members

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    2469f83 View commit details
    Browse the repository at this point in the history

  47. Add support for POWER4 report "responses"

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    35bf2e4 View commit details
    Browse the repository at this point in the history

  48. Check expected attributes in response tests

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f4a5352 View commit details
    Browse the repository at this point in the history

  49. Don't use "temp" shorthand

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9283431 View commit details
    Browse the repository at this point in the history

  50. Replace unit parameter parsing with power4 report parsing

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    33b3263 View commit details
    Browse the repository at this point in the history

  51. Add properties to device class and zone classes

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    2a498f5 View commit details
    Browse the repository at this point in the history

  52. Define device apply method and send ControlBasic commands

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    dc2ab8e View commit details
    Browse the repository at this point in the history

  53. Update defaults of ControlBasic

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8eea279 View commit details
    Browse the repository at this point in the history

  54. Fix typing violations

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    3c3b453 View commit details
    Browse the repository at this point in the history

  55. Clean up pylint violations

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    497789a View commit details
    Browse the repository at this point in the history

  56. Add run_mode properties

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    64070a5 View commit details
    Browse the repository at this point in the history

  57. Add to_dict to print device state

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    bea1236 View commit details
    Browse the repository at this point in the history

  58. Add DHW power state properties

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    74dbd58 View commit details
    Browse the repository at this point in the history

  59. Fix bad reference to _temp_type

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    02d923b View commit details
    Browse the repository at this point in the history

  60. FIx out of date FrameType references due to rebase

    @mill1000
    mill1000 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5ecd890 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Fix incorrect frame type on control commands and add basic testcase f… 

    …or command format
    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    07c124c View commit details
    Browse the repository at this point in the history

  2. Fix parsing of zone2 terminal type

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    44c02e7 View commit details
    Browse the repository at this point in the history

  3. Process responses from control basic commands as query basic responses

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    414c356 View commit details
    Browse the repository at this point in the history

  4. Extract TBH enable from basic query response

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    98ee626 View commit details
    Browse the repository at this point in the history

  5. Remove underscores on zone members

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    232e82e View commit details
    Browse the repository at this point in the history

  6. Rename fastdhw_state to dhw_fast_mode

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bc960d3 View commit details
    Browse the repository at this point in the history

  7. Expose TBH and DHW Fast mode as device properties

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    97a9f29 View commit details
    Browse the repository at this point in the history

  8. Add TBH and fast DHW mode to to_dict

    @mill1000
    mill1000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    772fc06 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Fix incorrect attributes names

    @mill1000
    mill1000 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e404da8 View commit details
    Browse the repository at this point in the history