Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform AWS 4.0 Provider Upgrade #286

Closed
JT-Bruch opened this issue Mar 11, 2022 · 1 comment · Fixed by #291
Closed

Terraform AWS 4.0 Provider Upgrade #286

JT-Bruch opened this issue Mar 11, 2022 · 1 comment · Fixed by #291
Labels
feature/terraform Missing feature from Terraform
Milestone

Comments

@JT-Bruch
Copy link

Good afternoon.

I am in the process of upgrading to the 4.4.0 terraform provider for AWS, however when I do so, I get these errors in the tf-module. It looks like the S3 configuration has changed significantly.

Error: Value for unconfigurable attribute
│ 
│   with module.backoffice_tf_next.module.proxy_config.aws_s3_bucket.proxy_config_store,
│   on .terraform/modules/backoffice_tf_next/modules/cloudfront-proxy-config/main.tf line 13, in resource "aws_s3_bucket" "proxy_config_store":
│   13:   acl           = "private"
│ 
│ Can't configure a value for "acl": its value will be decided automatically
│ based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.backoffice_tf_next.module.statics_deploy.aws_s3_bucket.static_upload,
│   on .terraform/modules/backoffice_tf_next/modules/statics-deploy/main.tf line 10, in resource "aws_s3_bucket" "static_upload":
│   10: resource "aws_s3_bucket" "static_upload" {
│ 
│ Can't configure a value for "versioning": its value will be decided
│ automatically based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.backoffice_tf_next.module.statics_deploy.aws_s3_bucket.static_upload,
│   on .terraform/modules/backoffice_tf_next/modules/statics-deploy/main.tf line 12, in resource "aws_s3_bucket" "static_upload":
│   12:   acl           = "private"
│ 
│ Can't configure a value for "acl": its value will be decided automatically
│ based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.backoffice_tf_next.module.statics_deploy.aws_s3_bucket.static_deploy,
│   on .terraform/modules/backoffice_tf_next/modules/statics-deploy/main.tf line 36, in resource "aws_s3_bucket" "static_deploy":
│   36: resource "aws_s3_bucket" "static_deploy" {
│ 
│ Can't configure a value for "lifecycle_rule": its value will be decided
│ automatically based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.backoffice_tf_next.module.statics_deploy.aws_s3_bucket.static_deploy,
│   on .terraform/modules/backoffice_tf_next/modules/statics-deploy/main.tf line 38, in resource "aws_s3_bucket" "static_deploy":
│   38:   acl           = "private"
│ 
│ Can't configure a value for "acl": its value will be decided automatically
│ based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.marketplace_tf_next.module.proxy_config.aws_s3_bucket.proxy_config_store,
│   on .terraform/modules/marketplace_tf_next/modules/cloudfront-proxy-config/main.tf line 13, in resource "aws_s3_bucket" "proxy_config_store":
│   13:   acl           = "private"
│ 
│ Can't configure a value for "acl": its value will be decided automatically
│ based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.marketplace_tf_next.module.statics_deploy.aws_s3_bucket.static_upload,
│   on .terraform/modules/marketplace_tf_next/modules/statics-deploy/main.tf line 10, in resource "aws_s3_bucket" "static_upload":
│   10: resource "aws_s3_bucket" "static_upload" {
│ 
│ Can't configure a value for "versioning": its value will be decided
│ automatically based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.marketplace_tf_next.module.statics_deploy.aws_s3_bucket.static_upload,
│   on .terraform/modules/marketplace_tf_next/modules/statics-deploy/main.tf line 12, in resource "aws_s3_bucket" "static_upload":
│   12:   acl           = "private"
│ 
│ Can't configure a value for "acl": its value will be decided automatically
│ based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.marketplace_tf_next.module.statics_deploy.aws_s3_bucket.static_deploy,
│   on .terraform/modules/marketplace_tf_next/modules/statics-deploy/main.tf line 36, in resource "aws_s3_bucket" "static_deploy":
│   36: resource "aws_s3_bucket" "static_deploy" {
│ 
│ Can't configure a value for "lifecycle_rule": its value will be decided
│ automatically based on the result of applying this configuration.
╵
╷
│ Error: Value for unconfigurable attribute
│ 
│   with module.marketplace_tf_next.module.statics_deploy.aws_s3_bucket.static_deploy,
│   on .terraform/modules/marketplace_tf_next/modules/statics-deploy/main.tf line 38, in resource "aws_s3_bucket" "static_deploy":
│   38:   acl           = "private"
│ 
│ Can't configure a value for "acl": its value will be decided automatically
│ based on the result of applying this configuration.

What are your thoughts on upgrading to the new version? Should I fork this in the meantime?

Thanks so much!

@ofhouse
Copy link
Member

ofhouse commented Mar 13, 2022

Yes, 4.0 changed some S3 configuration options.
Need to take a look at our own dependencies (terraform-aws-modules/lambda/aws & terraform-aws-apigateway-v2) if they are already compatible with the 4.x version.

In general I see nothing that speaks against to increase the minimum required aws provider to 4.x 👍

@ofhouse ofhouse added the feature/terraform Missing feature from Terraform label Mar 13, 2022
@ofhouse ofhouse added this to the Upcoming Minor milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/terraform Missing feature from Terraform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants