Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#215 and #195 - Updated breakpoints from 40.0rem to 42.0rem #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#215 and #195 - Updated breakpoints from 40.0rem to 42.0rem #265

wants to merge 1 commit into from

Conversation

gustsu
Copy link

@gustsu gustsu commented Oct 6, 2020

Description

I updated breakpoints from 40.0rem to 42.0rem in _Grid.sass and _Table.sass. This solves issue #205 and #192.

Code sample

This is a pretty small 2 line change so I didn't include a codepen link. I can include one if desired.

@nateberkopec
Copy link
Contributor

nateberkopec commented Oct 23, 2020 •
edited
Loading

I've noticed moving to 42rem also fixes column issues with iPhone 11 Max. I approve！

@juanbrujo
Copy link

merge?

@milouse
Copy link

milouse commented Oct 31, 2022

I allowed myself to integrate your changes in my own fork. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gustsu @nateberkopec @juanbrujo @milouse