Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example for Legal RAG with Milvus #1379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephen37
Copy link
Contributor

@stephen37 stephen37 commented Jul 16, 2024

This PR introduces an example of how to deal with LegaL RAG with Milvus. It is using Voyage AI Law embedding models as those are specifically trained on legal data.

  • A reference to a related issue in your repository.

    Each PR is related to an issue, and you need to list that issue.

  • A description of the changes proposed in the pull request.

    A brief introduction to this PR.

  • Add delight to the experience when all tasks are complete 🎉

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephen37

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

The code LGTM. As a notebook, I think it lacks some verbal explaination to make it a story. E.g. at the very begining, there could be explaination of typical RAG architecture. Then a brief touch on applying RAG on legal field and its practical benefit in business. Then some words on what's specially about this legal dataset.

@stephen37
Copy link
Contributor Author

@codingjaguar I added more context to the notebook, it's way better now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants