Add binary unittest to improve code coverage #972

cydrain · 2023-06-28T11:47:55Z

Issue: #960

Before

Overall coverage rate:
  lines......: 78.5% (2088 of 2661 lines)
  functions..: 55.3% (347 of 627 functions)

After

Overall coverage rate:
  lines......: 78.2% (2096 of 2679 lines)
  functions..: 61.6% (388 of 630 functions)

sre-ci-robot · 2023-06-28T11:47:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2023-06-28T11:48:29Z

@cydrain Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

cqy123456 · 2023-06-29T06:12:34Z

/lgtm

sre-ci-robot requested review from cqy123456 and yanliang567 June 28, 2023 11:47

sre-ci-robot added approved size/L labels Jun 28, 2023

mergify bot added the dco-passed DCO check passed. label Jun 28, 2023

mergify bot added do-not-merge/missing-related-issue and removed do-not-merge/missing-related-issue labels Jun 28, 2023

cydrain force-pushed the caiyd_add_binary_test_for_codecov branch from 817a680 to ce5eebd Compare June 29, 2023 02:28

Add binary unittest to improve code coverage

f68b445

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

cydrain force-pushed the caiyd_add_binary_test_for_codecov branch from ce5eebd to f68b445 Compare June 29, 2023 03:18

mergify bot added the ci-passed label Jun 29, 2023

sre-ci-robot assigned cqy123456 Jun 29, 2023

sre-ci-robot added the lgtm label Jun 29, 2023

sre-ci-robot merged commit ce027c2 into milvus-io:main Jun 29, 2023

cydrain deleted the caiyd_add_binary_test_for_codecov branch June 29, 2023 06:14

Provide feedback